[SPARK-58689][CORE][TESTS] Add tests for SparkStringUtils padding and abbreviation helpers - #57890
Open
uros-b wants to merge 2 commits into
Open
[SPARK-58689][CORE][TESTS] Add tests for SparkStringUtils padding and abbreviation helpers#57890uros-b wants to merge 2 commits into
uros-b wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adds
SparkStringUtilsSuite, coveringisBlank/isNotBlank,leftPad, bothrightPadoverloads, bothabbreviateoverloads,strip, andstringToSeq.Why are the changes needed?
SparkStringUtilscurrently has no test suite, while the sibling utilities in the same module (SparkErrorUtilsSuite,SparkFileUtilsSuite,VersionUtilsSuite, ...) each have one. The helpers are not incidental:leftPad/rightPadformat the column output ofDataset.show, andabbreviateis used to build Kubernetes application-name labels. The methods arrived across a series of changes that replaced Apache Commons and Guava equivalents, and none of those added direct tests.The three-argument
rightPad(str, width, padStr)holds the most error-prone arithmetic in the file (pad repetition plus truncation of the final repetition) and currently has no caller, so it had no coverage of any kind.Does this PR introduce any user-facing change?
No. Tests only.
How was this patch tested?
This is the test. Every expected value was derived by executing the current implementations rather than computed by hand, including the pad-truncation cases (
rightPad("a", 4, "xy")is"axyx") and the null pass-through paths. The suite was run locally: 6 tests, 27 assertions, all passing.The suite extends
AnyFunSuitewith thescalastyle:ignore funsuitemarker, matching every sibling suite in this module;common/utilsdoes not depend onspark-core, soSparkFunSuiteis not available here.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)