fix(ui): allow legal links to wrap naturally within text - #9369
Conversation
Allow the "Terms of Service" and "Privacy Policy" links in the sign-up legal consent label to wrap naturally across lines. They were previously styled `display: inline-flex`, which forced each link to wrap as a single unbreakable unit, leaving a gap at the end of the preceding line.
🦋 Changeset detectedLatest commit: cbc85ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@tuliren is attempting to deploy a commit to the Clerk Production Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
📝 WalkthroughWalkthroughThe legal consent checkbox now styles rendered links with Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
On the sign-up "Legal consent" screen, the "I agree to the Terms of Service and Privacy Policy" label is wrapped awkwardly, because the two legal links are rendered as
display: inline-flex, making each one an atomic inline box the browser cannot break inside. As a result,Privacy Policyalways wrapped to its own line, leaving a large gap at the end of the preceding line.This PR styles the links in the legal-consent label as
display: inline, letting the text break at the last fitting word so the line fills the available width before wrapping. The change is scoped to the consent label's links via its existingsx, so no other component is affected.To test the change:
pnpm dev:sandboxhttp://localhost:4000/sign-upPrivate Policylink now wraps around by the space.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change