docs: fix persistent environment file owner - #25747
Conversation
The nvm example incorrectly said only root could update the sandbox persistent environment file. Run both install commands as the agent user and document the file's actual ownership. Co-Authored-By: Claude <noreply@anthropic.com>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The change correctly adds user: "1000" to the file-append step and updates the explanatory prose to match the actual behavior of Docker's sandbox images (where /etc/sandbox-persistent.sh is owned by the agent user). No issues found in the changed lines.
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The change is a focused, accurate correction: user: "1000" is added to the append step so both install steps run as the agent user, and the accompanying prose is updated to reflect the corrected file ownership. The YAML and prose are consistent.
No high or medium severity issues found. Two minor style observations (not blocking):
- Line 150:
"can update"slightly understates certainty —"updates"would be more direct per the style guide. - Line 152–153: the em-dash spans a line break without a space on both sides; the style guide specifies spaces on either side of an em-dash.
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The fix correctly adds user: "1000" to the second install step (the cat >> /etc/sandbox-persistent.sh command) so it runs as the agent user who owns the file. The accompanying prose — "Both install steps run as user: "1000"" — is accurate since the first step already carried that field. No style violations, markdown issues, or accuracy problems were found in the added lines.
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The change correctly updates the nvm kit example to run both install steps as user: "1000", matching the actual file ownership of /etc/sandbox-persistent.sh in sandbox images. The explanatory prose accurately describes the behavior. No style violations, markdown issues, or content inaccuracies were found in the changed lines.
3 participants
Summary
Correct the nvm kit example to update /etc/sandbox-persistent.sh as the agent user, matching the file ownership in sandbox images.
@netlify /ai/sandboxes/customize/kit-examples/
Preview the kit examples
Closes docker/sbx-releases#313
Generated by Codex