Skip to content

feat(data-collection): Add sensitive key-value collection filter - #3025

Open
sl0thentr0py wants to merge 1 commit into
neel/data-collection/basefrom
neel/data-collection/sensitive
Open

feat(data-collection): Add sensitive key-value collection filter#3025
sl0thentr0py wants to merge 1 commit into
neel/data-collection/basefrom
neel/data-collection/sensitive

Conversation

@sl0thentr0py

@sl0thentr0py sl0thentr0py commented Jul 16, 2026

Copy link
Copy Markdown
Member

Description

  • Implement KeyValueCollection filtering behavior for :off, :allow_list, :deny_list
  • Sensitive list is filtered regardless of mode

Issues


Stack created with GitHub Stacks CLIGive Feedback 💬

@linear-code

linear-code Bot commented Jul 16, 2026

Copy link
Copy Markdown

RUBY-189

@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/sensitive branch 2 times, most recently from caa24a5 to 6a1469f Compare July 20, 2026 12:54
Comment thread sentry-ruby/lib/sentry/data_collection/key_value_collection.rb Outdated
Comment thread sentry-ruby/lib/sentry/data_collection/key_value_collection.rb Outdated
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/sensitive branch from 6a1469f to 29d2ec4 Compare July 20, 2026 12:57
Comment thread sentry-ruby/lib/sentry/data_collection/key_value_collection.rb
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/sensitive branch from 29d2ec4 to d86858a Compare July 20, 2026 13:02
Comment thread sentry-ruby/lib/sentry/data_collection/key_value_collection.rb
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/sensitive branch from d86858a to 284c040 Compare July 20, 2026 13:10
Comment thread sentry-ruby/lib/sentry/data_collection/key_value_collection.rb
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/sensitive branch from 284c040 to 801ff01 Compare July 20, 2026 14:11
Comment thread sentry-ruby/lib/sentry/configuration.rb Outdated
Comment thread sentry-ruby/lib/sentry/configuration.rb Outdated
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/sensitive branch 2 times, most recently from d90c1b7 to e649ed3 Compare July 20, 2026 14:13
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/sensitive branch from e649ed3 to 2672657 Compare July 20, 2026 14:31
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/sensitive branch 2 times, most recently from 53393da to 6f61522 Compare July 21, 2026 14:24
Comment thread sentry-ruby/lib/sentry/data_collection/key_value_collection.rb
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/sensitive branch from 6f61522 to e3d1a05 Compare July 22, 2026 11:49
Comment thread sentry-ruby/lib/sentry/data_collection/key_value_collection.rb
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/sensitive branch from e3d1a05 to a0dcc7a Compare July 22, 2026 12:07
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/sensitive branch from a0dcc7a to e3d1a05 Compare July 22, 2026 12:11
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/sensitive branch 2 times, most recently from ea1251f to 97bdffe Compare July 22, 2026 16:19
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/sensitive branch from 97bdffe to ea1251f Compare July 22, 2026 16:23

@solnic solnic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some non-blocking comments.

Comment thread sentry-ruby/lib/sentry/data_collection/key_value_collection.rb
Comment thread sentry-ruby/spec/sentry/data_collection/key_value_collection_spec.rb Outdated
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/sensitive branch from ea1251f to 064575b Compare August 10, 2026 12:06
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/sensitive branch 2 times, most recently from 9a402e1 to b8bdfe5 Compare August 10, 2026 12:18
Comment thread sentry-ruby/spec/sentry/data_collection/key_value_collection_spec.rb Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b8bdfe5. Configure here.

Comment thread sentry-ruby/spec/sentry/data_collection/key_value_collection_spec.rb Outdated
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/sensitive branch from b8bdfe5 to 8968e10 Compare August 10, 2026 12:30
@sl0thentr0py
sl0thentr0py force-pushed the neel/data-collection/sensitive branch from 8968e10 to a98375f Compare August 10, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(pii): Sensitive denylist + key-value collection modes helper

3 participants