Skip to content

ffi: keep wrapped functions non-constructible - #65184

Open
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:ffi-constructible-native-functions
Open

ffi: keep wrapped functions non-constructible#65184
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:ffi-constructible-native-functions

Conversation

@trivikr

@trivikr trivikr commented Aug 10, 2026

Copy link
Copy Markdown
Member

Fixes: #65183

Use concise method functions for Fast API and shared-buffer wrappers so they preserve the native FFI functions' non-constructible behavior.


Assisted-by: codex:gpt-5.6-sol

Use concise method functions for Fast API and shared-buffer wrappers so
they preserve the native FFI functions' non-constructible behavior.

Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: codex:gpt-5.6-sol
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/ffi

@nodejs-github-bot nodejs-github-bot added ffi Issues and PRs related to experimental Foreign Function Interface support. needs-ci PRs that need a full CI run. labels Aug 10, 2026
@trivikr trivikr added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 10, 2026
@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 47.82609% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.33%. Comparing base (6fec5e8) to head (edd2a79).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/ffi-shared-buffer.js 33.33% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65184      +/-   ##
==========================================
+ Coverage   90.32%   90.33%   +0.01%     
==========================================
  Files         760      760              
  Lines      248523   248527       +4     
  Branches    46896    46887       -9     
==========================================
+ Hits       224469   224507      +38     
+ Misses      15465    15459       -6     
+ Partials     8589     8561      -28     
Files with missing lines Coverage Δ
lib/internal/ffi/fast-api.js 94.80% <100.00%> (+0.02%) ⬆️
lib/internal/ffi-shared-buffer.js 55.57% <33.33%> (+0.16%) ⬆️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ffi Issues and PRs related to experimental Foreign Function Interface support. needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ffi: JavaScript wrappers make non-constructible native functions constructible

2 participants