[RFC,cmake] A layer of smoke: avoid by using file sets for library generation - #23061
Draft
ferdymercury wants to merge 4 commits into
Draft
[RFC,cmake] A layer of smoke: avoid by using file sets for library generation#23061ferdymercury wants to merge 4 commits into
ferdymercury wants to merge 4 commits into
Conversation
ferdymercury
changed the title
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 1a71b1b. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Note: this PR is totally experimental. It does not build, that's why it's marked as skip ci.
ROOT CMake macros are often... "a layer of smoke", masking common things such as PUBLIC and PRIVATE with ambiguous names such as DEPENDENCIES and LIBRARIES. No outside user (and often not inside ones) will know what they mean unless looking carefully in the instructions.
With CMake FILE_SETs, some macro stuff can be replaced with more standard CMake terminology. Clear advantage: an outside user with CMake knowledge will immediately know what you are doing no matter if it's the first time they look into ROOT. Otherwise, you need to dive in into a lot of cryptic macro layers...
This is a non-working draft, it specifies more the structure /philosophy rather than being functional. For discussion and sandbox experiments, the small xroofit library was chosen.
See also discussion in #20533 (comment)
Depends on #19941 --> maybe in November after branching 6.42 it can be merged ? Since the release of 6.44 will match ubu22 EOL so no longer cmake 3.22 ?